Greptile Summary

This PR introduces a first-class async programming model for modules: an @arpc decorator for dual-mode dispatch, a spawn/process_observable API for scheduling coroutines on the module's dedicated event loop, an async def main() generator contract for lifecycle setup/teardown, auto-binding of async handle_* methods, and an AsyncSpecProxy that bridges synchronous RPC calls into awaitables for callers that type their refs with async def specs.

• P0 — asyncio.Task(loop=loop) in _logging_task_factory (module.py:718): The loop kwarg was removed in Python 3.10; every coroutine scheduled on any module's event loop immediately raises TypeError, breaking the entire async task system on supported Python versions.

Confidence Score: 2/5

Not safe to merge: _logging_task_factory is broken on Python ≥ 3.10, making the entire async task system non-functional.

A single P0 finding caps the score at 2. The asyncio.Task(loop=loop) call in _logging_task_factory raises TypeError on any Python ≥ 3.10, which is the actively supported range. This factory is set on every module's event loop via get_loop(), so every coroutine scheduled by spawn(), process_observable(), or _start_main() would fail to create a task.

dimos/core/module.py — specifically _logging_task_factory at line 718

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant C as Sync Caller
    participant W as arpc Wrapper
    participant EL as Module Event Loop
    participant P as AsyncSpecProxy
    participant TP as ThreadPoolExecutor
    participant RL as Remote Module Loop

    C->>W: handle_x(msg) from RPC dispatcher
    W->>W: get_running_loop raises, running=None
    W->>EL: run_coroutine_threadsafe(coro)
    W->>W: future.result() blocks caller
    EL->>EL: await coro
    EL-->>C: result returned

    EL->>P: await self._ref.remote_method(x)
    P->>TP: run_in_executor(None, RpcCall)
    TP->>RL: run_coroutine_threadsafe(coro)
    RL-->>TP: result
    TP-->>EL: Future resolved

    C->>EL: start - run_coroutine_threadsafe gen anext
    EL->>EL: setup code then yield
    EL-->>C: setup done, start returns
    C->>EL: stop - run_coroutine_threadsafe gen anext
    EL->>EL: teardown then StopAsyncIteration
    EL-->>C: teardown done, stop returns

_{Reviews (4): Last reviewed commit: "feat(modules): async modules" | Re-trigger Greptile}

Want your agent to iterate on Greptile's feedback? Try greploops.